Conditions | 3 |
Total Lines | 63 |
Code Lines | 43 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | import { Inject } from '@nestjs/common'; |
||
30 | |||
31 | public async execute(command: CreateLeaveRequestCommand): Promise<string> { |
||
32 | const { |
||
33 | user, |
||
34 | endDate, |
||
35 | endsAllDay, |
||
36 | type, |
||
37 | startDate, |
||
38 | startsAllDay, |
||
39 | comment |
||
40 | } = command; |
||
41 | |||
42 | if ( |
||
43 | true === |
||
44 | (await this.doesLeaveRequestExistForPeriod.isSatisfiedBy( |
||
45 | user, |
||
46 | startDate, |
||
47 | endDate |
||
48 | )) |
||
49 | ) { |
||
50 | throw new LeaveRequestAlreadyExistForThisPeriodException(); |
||
51 | } |
||
52 | |||
53 | if ( |
||
54 | true === |
||
55 | (await this.doesLeaveExistForPeriod.isSatisfiedBy( |
||
56 | user, |
||
57 | startDate, |
||
58 | endDate |
||
59 | )) |
||
60 | ) { |
||
61 | throw new EventsOrLeavesAlreadyExistForThisPeriodException(); |
||
62 | } |
||
63 | |||
64 | const leaveRequest = await this.leaveRequestRepository.save( |
||
65 | new LeaveRequest( |
||
66 | user, |
||
67 | type, |
||
68 | startDate, |
||
69 | startsAllDay, |
||
70 | endDate, |
||
71 | endsAllDay, |
||
72 | comment |
||
73 | ) |
||
74 | ); |
||
75 | |||
76 | this.commandBus.execute( |
||
77 | new CreateNotificationCommand( |
||
78 | NotificationType.POST, |
||
79 | this.translator.translate( |
||
80 | 'leave-requests-create-notification-message', |
||
81 | { |
||
82 | userFirstName: leaveRequest.getUser().getFirstName(), |
||
83 | link: `${this.configService.get<string>( |
||
84 | 'PERMACOOP_BASE_URL' |
||
85 | )}/app/people/leaves/${leaveRequest.getId()}` |
||
86 | } |
||
87 | ), |
||
88 | leaveRequest |
||
89 | ) |
||
90 | ); |
||
91 | |||
92 | return leaveRequest.getId(); |
||
93 | } |
||
95 |